Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installation: CNF Installation (7) Verify new installation process #2177

Merged
merged 2 commits into from
Nov 28, 2024

Commits on Nov 28, 2024

  1. Feat: Add spec tests for new installation method and fix minor bugs

    Refs: #2168
    - New setup spec tests were introduced to verify that the installation
      method from #2161 works as intended.
    - Three distinct issues were discovered and resolved:
      * Helm directories with variable depth levels could not be discovered
      after initialization (resolved through File.basename).
      * Configs that weren't named cnf-testsuite.yml could not
      be discovered after initialization (resolved by changing the name
      internally when copying the file).
      * Existence of manifest folder was not checked (resolved by adding an
      if check).
    - Additionally a common point of failure was added with a failure
      message that was previously not present.
    - The issue #2176 was also discovered during attempted deployment of
      sample-cnfs/sample-elk-stack which was also added in this commit and
      is to be used in future spec test.
    
    Signed-off-by: svteb <[email protected]>
    svteb committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    8c37d23 View commit details
    Browse the repository at this point in the history
  2. Fix: apply suggestions from code review

    Co-authored-by: Cédric Ollivier <[email protected]>
    svteb and collivier authored Nov 28, 2024
    Configuration menu
    Copy the full SHA
    79e89e4 View commit details
    Browse the repository at this point in the history