Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clerk-js): UI fixes on <SignIn/> and <SignUp/> to match new design #2512

Merged
merged 11 commits into from
Jan 11, 2024
Merged

fix(clerk-js): UI fixes on <SignIn/> and <SignUp/> to match new design #2512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
512b700
fix(clerk-js): Divider text font-weight
marcelscruz Jan 8, 2024
a6ca75b
fix(clerk-js): Input box-shadow
marcelscruz Jan 8, 2024
6a95c13
fix(clerk-js): Primary button background and box-shadow
marcelscruz Jan 8, 2024
5cf7029
fix(clerk-js): Form secondary action text size and weight
marcelscruz Jan 8, 2024
9de04f6
fix(clerk-js): Font sizes for xs and sm and "optional" label color
marcelscruz Jan 8, 2024
9032a3d
fix(clerk-js): Phone input box-shadow
marcelscruz Jan 8, 2024
7bc31ed
fix(clerk-js): Alternative methods back button text
marcelscruz Jan 8, 2024
ee9bc89
fix(clerk-js): Update tests
marcelscruz Jan 8, 2024
f524eb9
fix(clerk-js): Revert font-size change for xs and sm
marcelscruz Jan 9, 2024
b12201f
fix(clerk-js): Reduce breaking changes in localization
octoper Jan 11, 2024
9603b60
fix(clerk-js): Revert wrongly removed disabled styles from Input comp…
octoper Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/light-apples-joke.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
2 changes: 2 additions & 0 deletions .changeset/soft-rats-grab.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
2 changes: 2 additions & 0 deletions .changeset/yellow-frogs-teach.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
2 changes: 1 addition & 1 deletion packages/clerk-js/src/ui/elements/Divider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const Divider = (props: DividerProps) => {
<Text
localizationKey={!dividerText ? localizationKeys('dividerText') : dividerText}
elementDescriptor={descriptors.dividerText}
variant='subtitle'
variant='body'
colorScheme='neutral'
sx={t => ({ margin: `0 ${t.space.$4}` })}
/>
Expand Down
3 changes: 2 additions & 1 deletion packages/clerk-js/src/ui/elements/FieldControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ const FieldAction = (
elementId={descriptors.formFieldLabel.setId(fieldId)}
isDisabled={isDisabled}
colorScheme='primary'
variant='buttonSmall'
onClick={e => {
e.preventDefault();
props.onClick?.(e);
Expand All @@ -78,7 +79,7 @@ const FieldOptionalLabel = () => {
elementId={descriptors.formFieldHintText.setId(fieldId)}
as='span'
variant='caption'
colorScheme='neutral'
colorScheme='tertiary'
isDisabled={isDisabled}
/>
);
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/ui/primitives/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const { applyVariants, filterProps } = createVariants((theme, props: OwnProps) =
borderRadius: 'inherit',
zIndex: -1,
inset: 0,
background: `linear-gradient(180deg, ${theme.colors.$whiteAlpha300} 0%, ${theme.colors.$transparent} 100%)`,
background: `linear-gradient(180deg, ${theme.colors.$whiteAlpha150} 0%, ${theme.colors.$transparent} 100%)`,
},
':after': {
position: 'absolute',
Expand All @@ -65,7 +65,7 @@ const { applyVariants, filterProps } = createVariants((theme, props: OwnProps) =
opacity: 0,
transitionProperty: theme.transitionProperty.$common,
transitionDuration: theme.transitionDuration.$controls,
background: `linear-gradient(180deg, ${theme.colors.$whiteAlpha200} 0%, ${theme.colors.$transparent} 100%)`,
background: `linear-gradient(180deg, ${theme.colors.$whiteAlpha100} 0%, ${theme.colors.$transparent} 100%)`,
},
':hover::after': {
opacity: 1,
Expand Down
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/primitives/Text.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ const { applyVariants, filterProps } = createVariants(theme => {
danger: { color: theme.colors.$danger500 },
success: { color: theme.colors.$success500 },
neutral: { color: theme.colors.$colorTextSecondary },
tertiary: { color: theme.colors.$colorTextTertiary },
inherit: { color: 'inherit' },
},
truncate: {
Expand Down
Loading