fix(clerk-js): UI fixes on <SignIn/> and <SignUp/> to match new design #2512
Conversation
🦋 Changeset detectedLatest commit: 9603b60 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marcelscruz
requested review from
anagstef,
panteliselef,
desiprisg and
octoper
and removed request for
panteliselef
|
!preview |
|
Hey @octoper, your preview is available.
|
| xs: '0.6875rem', | ||
| sm: '0.75rem', |
There was a problem hiding this comment.
We need to keep these numbers as is. These were carefully selected to be as close as possible to the font-sizes we want, while also keep the correct ratio between all font-sizes.
There was a problem hiding this comment.
Reverted it, thanks for catching it.
Some font sizes in our design are slightly different than those, so I'll leave it as is for the time being to avoid adding many custom sizes.
At some point, it'd be good for us to align both codebase and design sizes.
| @@ -45,14 +45,14 @@ const { applyVariants, filterProps } = createVariants((theme, props: OwnProps) = | |||
| primary: { | |||
| backgroundColor: theme.colors.$primary500, | |||
| color: theme.colors.$colorTextOnPrimaryBackground, | |||
| ...common.buttonShadow, | |||
| ...common.buttonShadow(theme), | |||
|
!preview |
octoper
force-pushed
the
marcel/retheme-sign-in-up-ui-fixes
branch
from
3470cd6 to
f524eb9
Compare
|
!preview |
|
!preview |
Description
Fixes the issues listed on this ticket.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore