Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(repo): Enable clerk@v5 release process #1837

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

dimkl
Copy link
Contributor

@dimkl dimkl commented Oct 6, 2023

Description

To prepare for the next major version (clerk@v5) we need to change our current release process.

Changes:

  • Introduced main-v4 branch to support releasing fixes and changes until next major version is ready for release
  • Consider main-v4 as the stable branch that produces staging and production releases
  • Consider main branch as the experimental branch that produces canary releases
  • The canary releases broadcast messages to clerkinc/v5-testbench that triggers a vercel preview release

When next major version is stable and released the staging and production releases will be produced from the main branch. The main-v4 will NOT be deleted until it's not considered LTS any more.

This PR will be merged after those PRs are being merged: https://github.com/clerkinc/javascript/pulls?q=is%3Apr+is%3Aopen+label%3Av5-pre-release

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@dimkl dimkl self-assigned this Oct 6, 2023
@dimkl dimkl requested a review from a team as a code owner October 6, 2023 14:28
@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2023

🦋 Changeset detected

Latest commit: 6110b0f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dimkl dimkl force-pushed the js-791-clerk-v5-release-process branch 2 times, most recently from 9e08961 to 5ee35f0 Compare October 6, 2023 14:30
@dimkl dimkl force-pushed the js-791-clerk-v5-release-process branch 4 times, most recently from 787a9db to b2014e3 Compare October 9, 2023 13:44
Copy link
Member

@nikosdouvlis nikosdouvlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this wait for #1854 to be merged as these scripts have changed a bit?

@dimkl
Copy link
Contributor Author

dimkl commented Oct 10, 2023

@nikosdouvlis i will rebase it and have it ready to merge after the #1854

@dimkl dimkl requested a review from nikosdouvlis October 10, 2023 16:47
@dimkl dimkl force-pushed the js-791-clerk-v5-release-process branch 8 times, most recently from b374800 to 0ea4ca6 Compare October 16, 2023 12:51
@dimkl dimkl force-pushed the js-791-clerk-v5-release-process branch 2 times, most recently from 7b98e6f to 1d72b2d Compare October 17, 2023 10:40
@dimkl
Copy link
Contributor Author

dimkl commented Oct 17, 2023

Blocked by #1898

@dimkl dimkl force-pushed the js-791-clerk-v5-release-process branch 2 times, most recently from 2dc5715 to b60785d Compare October 19, 2023 08:02
@dimkl dimkl force-pushed the js-791-clerk-v5-release-process branch 3 times, most recently from 7133b7a to 2276921 Compare October 24, 2023 17:20
dimkl added 3 commits October 24, 2023 12:34
Until clerk@v5 is ready for release we will be using
the main-v4 branch for staging and production releases
and every commit and changelog entry SHOULD be committed
in both main-v4 and main branches.
The main branch will be used to produce canary releases.
The main branch will produce canary releases until the
next major version is ready for release. To produce a
staging and production release, open a PR from the main-v4
branch.
@dimkl dimkl force-pushed the js-791-clerk-v5-release-process branch from 2276921 to 6110b0f Compare October 24, 2023 19:34
@dimkl dimkl enabled auto-merge October 24, 2023 19:35
@dimkl dimkl added this pull request to the merge queue Oct 24, 2023
Merged via the queue into main with commit 8b3a53e Oct 24, 2023
12 checks passed
@dimkl dimkl deleted the js-791-clerk-v5-release-process branch October 24, 2023 19:48
@clerk-cookie
Copy link
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants