Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(repo): Replace clerk.dev with clerk.com #1878

Merged
merged 1 commit into from
Oct 26, 2023
Merged

chore(repo): Replace clerk.dev with clerk.com #1878

merged 1 commit into from
Oct 26, 2023

Conversation

dimkl
Copy link
Contributor

@dimkl dimkl commented Oct 13, 2023

Description

Since we have completely migrated to clerk.com, this PR replaces all references of the previous domain (clerk.dev) to clerk.com.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@dimkl dimkl requested a review from agis October 13, 2023 12:17
@dimkl dimkl self-assigned this Oct 13, 2023
@dimkl dimkl requested a review from a team as a code owner October 13, 2023 12:17
@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 9fe869b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
gatsby-plugin-clerk Patch
@clerk/clerk-js Patch
@clerk/clerk-sdk-node Patch
@clerk/backend Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/shared Patch
@clerk/clerk-expo Patch
@clerk/chrome-extension Patch
@clerk/remix Patch
@clerk/clerk-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dimkl dimkl requested a review from georgepsarakis October 13, 2023 12:18
@dimkl dimkl force-pushed the hou-46-clerk-dev branch 2 times, most recently from ee766af to 66e547c Compare October 13, 2023 12:56
anagstef
anagstef requested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@anagstef anagstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Just a small change!

agis
agis approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@agis agis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (only one note regarding backwards compatibility)! 🚀

packages/backend/src/constants.ts
@@ -1,4 +1,4 @@
export const API_URL = 'https://api.clerk.dev';
export const API_URL = 'https://api.clerk.com';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ I'm wondering if there could be use cases that depend on that value, for example:

  • test suites asserting things like expect(request).to('api.clerk.dev')
  • strict firewalls configured to only allow outgoing traffic to api.clerk.dev and not api.clerk.com

These seem unlikely to me, but just wanted to point out that this has some small chance of breaking someone.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strict firewalls configured to only allow outgoing traffic to api.clerk.dev and not api.clerk.com

@agis Could you check the firewall rules if we support the clerk.com for all of our workers services (eg img.clerk.com)? If so, I think we could proceed with this PR.

test suites asserting things like expect(request).to('api.clerk.dev')

Could you elaborate more on this? In the javascript repo, I believe that all the tests are updated to use clerk.com

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring to customers' test suites and WAF, not our own (our own WAF is fine, since clerk.com is already used by a handful of customers already). I was just trying to envision any cases where changing this constant's value would break customers.

Feel free to disregard my comment if you believe this is highly unlikely.

Copy link
Contributor Author

@dimkl dimkl Oct 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the above comments i think we should introduce the change of clerk.dev -> clerk.com) as part of the next major version and add references in the migration guide and changelog about changing the clerk domains to avoid causing issues in customers depending the requests to our systems (eg mocking the requests).

@dimkl dimkl requested a review from anagstef October 16, 2023 10:48
anagstef
anagstef approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@anagstef anagstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimkl
Copy link
Contributor Author

dimkl commented Oct 16, 2023

Blocked by #1837

nikosdouvlis
nikosdouvlis approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@nikosdouvlis nikosdouvlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup @dimkl

@dimkl dimkl enabled auto-merge October 26, 2023 20:17
@dimkl dimkl added this pull request to the merge queue Oct 26, 2023
Merged via the queue into main with commit 71663c5 Oct 26, 2023
12 checks passed
@dimkl dimkl deleted the hou-46-clerk-dev branch October 26, 2023 20:37
@clerk-cookie clerk-cookie mentioned this pull request Nov 1, 2023
Merged
tmilewski pushed a commit that referenced this pull request Nov 17, 2023
@dimkl @tmilewski
chore(repo): Replace clerk.dev with clerk.com (#1878)
038ddc9
@clerk-cookie
Copy link
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@panteliselef panteliselef panteliselef left review comments

@agis agis agis approved these changes

@desiprisg desiprisg desiprisg approved these changes

@anagstef anagstef anagstef approved these changes

@nikosdouvlis nikosdouvlis nikosdouvlis approved these changes

@georgepsarakis georgepsarakis Awaiting requested review from georgepsarakis

Assignees

@dimkl dimkl

Labels
backend clerk-js expo fastify gatsby nextjs sdk-node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dimkl @clerk-cookie @agis @nikosdouvlis @anagstef @panteliselef @desiprisg