chore(clerk-js): Address PR comments

clerk · Nov 3, 2023 · ba188b6 · ba188b6
1 parent 904cd28
commit ba188b6
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/packages/clerk-js/src/core/resources/Permission.ts b/packages/clerk-js/src/core/resources/Permission.ts
@@ -11,7 +11,7 @@ export class Permission extends BaseResource implements PermissionResource {
   key!: string;
   name!: string;
   description!: string;
-  type!: 'system';
+  type!: 'system' | 'user';
   createdAt!: Date;
   updatedAt!: Date;
 

diff --git a/packages/clerk-js/src/ui/components/OrganizationProfile/MemberListTable.tsx b/packages/clerk-js/src/ui/components/OrganizationProfile/MemberListTable.tsx
@@ -138,19 +138,19 @@ export const RoleSelect = (props: {
 
   const shouldDisplayLegacyRoles = !roles;
 
-  const legacy_roles: Array<{ label: string; value: MembershipRole }> = [
+  const legacyRoles: Array<{ label: string; value: MembershipRole }> = [
     { label: 'admin', value: 'admin' },
     { label: 'basic_member', value: 'basic_member' },
   ];
 
-  const legacy_excludedRoles: Array<{ label: string; value: MembershipRole }> = [
+  const legacyExcludedRoles: Array<{ label: string; value: MembershipRole }> = [
     { label: 'guest_member', value: 'guest_member' },
   ];
   const { localizeCustomRole } = useLocalizeCustomRoles();
 
-  const selectedRole = [...(roles || []), ...legacy_roles, ...legacy_excludedRoles].find(r => r.value === value);
+  const selectedRole = [...(roles || []), ...legacyRoles, ...legacyExcludedRoles].find(r => r.value === value);
 
-  const localizedOptions = (!shouldDisplayLegacyRoles ? roles : legacy_roles).map(role => ({
+  const localizedOptions = (!shouldDisplayLegacyRoles ? roles : legacyRoles).map(role => ({
     value: role.value,
     label: localizeCustomRole(role.value) || role.label,
   }));

diff --git a/packages/clerk-js/src/ui/hooks/useFetch.ts b/packages/clerk-js/src/ui/hooks/useFetch.ts
@@ -1,4 +1,4 @@
-import { useLayoutEffect, useRef } from 'react';
+import { useEffect, useRef } from 'react';
 
 import { useLoadingStatus } from './useLoadingStatus';
 import { useSafeState } from './useSafeState';
@@ -17,7 +17,7 @@ export const useFetch = <T>(
 
   const fetcherRef = useRef(fetcher);
 
-  useLayoutEffect(() => {
+  useEffect(() => {
     if (!fetcherRef.current) {
       return;
     }

diff --git a/packages/types/src/json.ts b/packages/types/src/json.ts
@@ -386,7 +386,7 @@ export interface PermissionJSON extends ClerkResourceJSON {
   key: string;
   name: string;
   description: string;
-  type: 'system';
+  type: 'system' | 'user';
   created_at: number;
   updated_at: number;
 }

diff --git a/packages/types/src/permission.ts b/packages/types/src/permission.ts
@@ -7,7 +7,7 @@ export interface PermissionResource extends ClerkResource {
   id: string;
   key: string;
   name: string;
-  type: 'system';
+  type: 'system' | 'user';
   description: string;
   createdAt: Date;
   updatedAt: Date;