chore(clerk-js): Improve types & add comments

clerk · Nov 3, 2023 · 904cd28 · 904cd28
1 parent bf51225
commit 904cd28
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/packages/clerk-js/src/ui/components/OrganizationProfile/ActiveMembersList.tsx b/packages/clerk-js/src/ui/components/OrganizationProfile/ActiveMembersList.tsx
@@ -69,7 +69,7 @@ export const ActiveMembersList = () => {
 const MemberRow = (props: {
   membership: OrganizationMembershipResource;
   onRemove: () => unknown;
-  options: any;
+  options: Parameters<typeof RoleSelect>[0]['roles'];
   onRoleChange: (role: string) => unknown;
 }) => {
   const { membership, onRemove, onRoleChange, options } = props;

diff --git a/packages/clerk-js/src/ui/hooks/useFetchRoles.ts b/packages/clerk-js/src/ui/hooks/useFetchRoles.ts
@@ -4,6 +4,10 @@ import { customRoleLocalizationKey, roleLocalizationKey } from '../utils';
 import { useFetch } from './useFetch';
 
 const getRolesParams = {
+  /**
+   * Fetch at most 20 roles, it is not expected for an app to have more.
+   * We also prevent the creation of more than 20 roles in dashboard.
+   */
   pageSize: 20,
 };
 export const useFetchRoles = () => {