Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORGS-67: Update user serializer to add CreateOrganizationsLimit field #305

Merged

Conversation

NicolasLopes7
Copy link
Contributor

@NicolasLopes7 NicolasLopes7 commented Jul 19, 2024

WARNING: This only should be merged after this change is deployed to production!

This PR adds the CreateOrganizationsLimit field for the User serializer and user update params structs.

@NicolasLopes7 NicolasLopes7 requested a review from a team as a code owner July 19, 2024 13:41
Copy link
Member

@gkats gkats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but let's make sure we support the field in our update operation in production before we merge.

@@ -98,6 +98,7 @@ type UpdateParams struct {
BackupCodes *[]string `json:"backup_codes,omitempty"`
DeleteSelfEnabled *bool `json:"delete_self_enabled,omitempty"`
CreateOrganizationEnabled *bool `json:"create_organization_enabled,omitempty"`
CreateOrganizationsLimit *int `json:"create_organizations_limit,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Is support for this field coming soon or already available?

I can't find it in our docs: https://clerk.com/docs/reference/backend-api/tag/Users#operation/UpdateUser

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, it's pending on this PR https://github.com/clerk/clerk_go/pull/7124! I'll add to the readme a warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants