nicolas/dash 329 dapi delete ability to delete passkey #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasLopes7
force-pushed
the
nicolas/dash-329-dapi-delete-ability-to-delete-passkey
branch
from
505d6dc to
3445b5e
Compare
Co-authored-by: Kevin Wang <[email protected]>
Co-authored-by: Kevin Wang <[email protected]>
| }, | ||
| } | ||
| client := NewClient(config) | ||
| passkey, err := client.DeletePasskey(context.Background(), userID, passkeyIdentificationID) |
There was a problem hiding this comment.
❓ Do we need to seed a passkey?
What happens if we call client.DeletePasskey twice in this test?
There was a problem hiding this comment.
the test only asserts the http call for BAPI through the transporter. Defined here
There was a problem hiding this comment.
I see, so Out is effectively the mocked-expected-response
thiskevinwang
approved these changes
Sep 3, 2024
mzhong9723
approved these changes
Sep 3, 2024
NicolasLopes7
deleted the
nicolas/dash-329-dapi-delete-ability-to-delete-passkey
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new method from a new BAPI endpoint to delete passkeys. It's all under the users' client.