feat: Instance Settings API #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API operations for instance settings. Update instance settings, update instance restrictions and update instance organization settings.
gkats
force-pushed
the
core-1512-instance
branch
from
f8b310e to
c5cbc42
Compare
georgepsarakis
approved these changes
Feb 12, 2024
| @@ -279,6 +279,35 @@ func TestBackendCall_SuccessfulResponse_GetRequest(t *testing.T) { | |||
| assert.JSONEq(t, rawJSON, string(resource.Response.RawJSON)) | |||
| } | |||
|
|
|||
| // TestBackendCall_SuccessfulResponse_EmptyResponse tests successful | |||
| // responses with no response body. | |||
| func TestBackendCall_SuccessfulResponse_EmptyResponse(t *testing.T) { | |||
| var argsRE = regexp.MustCompile("^.+\\)\\s\\(") | ||
| var returnRE = regexp.MustCompile("^.+\\)") | ||
| var argsRE = regexp.MustCompile("^.+\\)\\s[\\(e]") | ||
| var returnRE = regexp.MustCompile("^.+\\s{") |
There was a problem hiding this comment.
💡 Mostly an idea/suggestion for possible future improvement, definitely not a current action item: we can use AST parsing to perform code generation in a possibly more maintainable way in the future: https://eli.thegreenplace.net/2021/rewriting-go-source-code-with-ast-tooling/
There was a problem hiding this comment.
Yes, this "generator" is a disgrace. 😞
There was a problem hiding this comment.
Gets the work done is what matters 🥇
Merged
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API operations for instance settings. Update instance settings, update instance restrictions and update instance organization settings.