feat: Users API #234
Merged
feat: Users API #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkats
force-pushed
the
core-1512-users
branch
from
beb910c to
896e2ac
Compare
user/client.go
Outdated
|
|
||
| type CreateParams struct { | ||
| clerk.APIParams | ||
| EmailAddresses []string `json:"email_address,omitempty"` |
There was a problem hiding this comment.
❓ Would you mind reminding me why we don't need to use pointer to slices? Is it because here we don't need to differentiate between existing parameter and empty?
There was a problem hiding this comment.
We do have to use pointer for slices as well! It's my mistake. Updated.
user/client.go
Outdated
| PrivateMetadata *json.RawMessage `json:"private_metadata,omitempty"` | ||
| UnsafeMetadata *json.RawMessage `json:"unsafe_metadata,omitempty"` | ||
| TOTPSecret *string `json:"totp_secret,omitempty"` | ||
| BackupCodes []string `json:"backup_codes,omitempty"` |
There was a problem hiding this comment.
❓ Same question as above with regard to pointer to slice.
user/client.go
Outdated
| q.Add("user_id", v) | ||
| } | ||
| if params.LastActiveAtSince != nil { | ||
| q.Add("limit", strconv.FormatInt(*params.LastActiveAtSince, 10)) |
There was a problem hiding this comment.
🔧 Not sure if I'm missing something:
Suggested change
| q.Add("limit", strconv.FormatInt(*params.LastActiveAtSince, 10)) | |
| q.Add("last_active_at_since", strconv.FormatInt(*params.LastActiveAtSince, 10)) |
There was a problem hiding this comment.
Great catch, thanks! Updated.
gkats
force-pushed
the
core-1512-users
branch
from
896e2ac to
f1e8ef8
Compare
Added support for the Users API. Available operations are Create, Get, List, Count, Update, UpdateMetadata, Delete, DeleteMFA, Ban, Unban, Lock, Unlock and ListOrganizationMemberships.
gkats
force-pushed
the
core-1512-users
branch
from
f1e8ef8 to
0c79528
Compare
georgepsarakis
approved these changes
Feb 9, 2024
Merged
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the Users API. Available operations are Create, Get, List, Count, Update, UpdateMetadata, Delete, DeleteMFA, Ban, Unban, Lock, Unlock and ListOrganizationMemberships.