Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Organizations API #226

Merged
merged 1 commit into from
Feb 8, 2024
Merged

feat: Organizations API #226

merged 1 commit into from
Feb 8, 2024

Conversation

gkats
Copy link
Member

@gkats gkats commented Feb 8, 2024

Added support for the Organizations API. The available operations are Create, Read, Update, Delete, List, DeleteLogo and UpdateMetadata.

@gkats gkats requested a review from a team as a code owner February 8, 2024 07:10
organization.go Outdated
// LogoURL is the URL of the organization's logo.
//
// Deprecated: Use ImageURL instead.
LogoURL *string `json:"logo_url,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ As this is a deprecated property, i believe we should stop using on the new major version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same opinion. Same for deprecated endpoints.

However, we had a discussion with @alex-ntousias and he suggested that we keep everything that we support in v1 so that we make the transition to v2 easier.

I guess for struct fields with a clear alternative things are easier. I'll drop the field.

Added support for the Organizations API. The available operations are
Create, Read, Update, Delete, List, DeleteLogo and UpdateMetadata.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants