feat: Email Addresses API #224
Conversation
| Error json.RawMessage `json:"error,omitempty"` | ||
| } | ||
|
|
||
| type LinkedIdentification struct { |
There was a problem hiding this comment.
I don't like this name, so if you have something better to suggest, please do!
There was a problem hiding this comment.
Sounds fine to me. I would maybe omit the Identification prefix from the struct field names.
| @@ -422,3 +422,8 @@ func String(v string) *string { | |||
| func Int64(v int64) *int64 { | |||
| return &v | |||
| } | |||
|
|
|||
| // Bool returns a pointer to the provided bool value. | |||
| func Bool(v bool) *bool { | |||
There was a problem hiding this comment.
🔧 Suggestion since this function is exported:
| func Bool(v bool) *bool { | |
| func BoolPtr(v bool) *bool { |
| Error json.RawMessage `json:"error,omitempty"` | ||
| } | ||
|
|
||
| type LinkedIdentification struct { |
There was a problem hiding this comment.
Sounds fine to me. I would maybe omit the Identification prefix from the struct field names.
| client := NewClient(config) | ||
| _, err := client.Create(context.Background(), &CreateParams{}) | ||
| require.Error(t, err) | ||
| apiErr, ok := err.(*clerk.APIErrorResponse) |
There was a problem hiding this comment.
💡 Perhaps a helper is useful?
apiErr, ok := clerk.AsErrorResponse(err)There was a problem hiding this comment.
Good idea. However, I cannot see how this would help.
I imagine that if we change the APIErrorResponse type, even if we had the helper, we would still have to change the code that uses the error response type. 🤔
Happy to add the helper in a separate PR.
There was a problem hiding this comment.
It would mostly serve as a guide. Autocompletion may help you write the conversion faster too. Otherwise someone must probably remember or look up the error type? The rest of the code will remain the same, you're absolutely right!
Added support for the Email Addresses API operations Create, Read, Update and Delete.
gkats
force-pushed
the
core-1512-email-addresses
branch
from
a3ac8e3 to
beba9f0
Compare
Added support for the Email Addresses API operations Create, Read, Update and Delete.