feat: Clients API #223
Merged
feat: Clients API #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added operations for the Clients API; Get, Verify and List. Added types for Client and Session.
georgepsarakis
approved these changes
Feb 7, 2024
| if rt.Method != "" { | ||
| require.Equal(rt.T, rt.Method, r.Method) | ||
| if rt.Query != nil { | ||
| require.Equal(rt.T, rt.Query.Encode(), r.URL.Query().Encode()) |
There was a problem hiding this comment.
❓ Is order deterministic when encoding multiple parameters? It might be, just pointing out in case it causes any flakiness whatsoever. I think assertion functions should be capable of comparing the map object though 🤔
There was a problem hiding this comment.
I thought about flakiness too, but I opted to leave it like this until an actual problem arises.
Merged
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added operations for the Clients API; Get, Verify and List.
Added types for Client and Session.