feat: Actor token API operations #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkats
force-pushed
the
core-1512-actor-tokens
branch
from
7b8c3a9 to
960ad16
Compare
georgepsarakis
approved these changes
Feb 1, 2024
| req := clerk.NewAPIRequest(http.MethodPost, path) | ||
| token := &clerk.ActorToken{} | ||
| err = clerk.GetBackend().Call(ctx, req, token) | ||
| return token, err |
There was a problem hiding this comment.
❓ Do you want to return nil or error or a pointer to empty struct? Because as it is now, it seems more suitable to return the empty value instead of a pointer.
There was a problem hiding this comment.
You mean because we return either nil or the pointer and we should be consistent and always return one or the other in case of error?
There was a problem hiding this comment.
Usually with pointers as return values we see in the code something like:
if err != nil {
return nil, err
}Here we return a pointer to empty struct which is not nil. Technically, non-nil error values should always take precedence at the call site. I am personally in favor for returning values not pointers:
return clerk.ActorToken{}, errAdded the types and operations for actor tokens. Create and Revoke are supported.
gkats
force-pushed
the
core-1512-actor-tokens
branch
from
960ad16 to
096c7ce
Compare
Merged
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Added the types and operations for actor tokens. Create and Revoke are supported.
Related Issue (optional)