Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice fixes for when mailing key does not exist #31640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Notice fixes for when mailing key does not exist #31640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions templates/CRM/Mailing/Page/Report.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@
<tr><td class="label"><a href="{$report.event_totals.links.delivered}">{ts}Successful Deliveries{/ts}</a></td>
<td>{$report.event_totals.delivered} ({$report.event_totals.delivered_rate|string_format:"%0.2f"}%)</td>
<td>{$report.event_totals.actionlinks.delivered}</td></tr>
{if $report.mailing.open_tracking}
{if array_key_exists('mailing', $report) && $report.mailing.open_tracking}
<tr><td class="label"><a href="{$report.event_totals.links.opened}&distinct=1">{ts}Unique Opens{/ts}</a></td>
<td>{$report.event_totals.opened} ({$report.event_totals.opened_rate|string_format:"%0.2f"}%)</td>
<td>{$report.event_totals.actionlinks.opened_unique}</td></tr>
<tr><td class="label"><a href="{$report.event_totals.links.opened}">{ts}Total Opens{/ts}</a></td>
<td>{$report.event_totals.total_opened}</td>
<td>{$report.event_totals.actionlinks.opened}</td></tr>
{/if}
{if $report.mailing.url_tracking}
{if array_key_exists('mailing', $report) && $report.mailing.url_tracking}
<tr><td class="label"><a href="{$report.event_totals.links.clicks}">{ts}Click-throughs{/ts}</a></td>
<td>{$report.event_totals.url} ({$report.event_totals.clickthrough_rate|string_format:"%0.2f"}%)</td>
<td>{$report.event_totals.actionlinks.clicks}</td></tr>
Expand Down Expand Up @@ -119,7 +119,7 @@
{/if}
</fieldset>

{if $report.mailing.url_tracking && $report.click_through|@count > 0}
{if array_key_exists('mailing', $report) && $report.mailing.url_tracking && $report.click_through|@count > 0}
<fieldset>
<legend>{ts}Click-through Summary{/ts}</legend>
{strip}
Expand Down Expand Up @@ -148,7 +148,7 @@
<legend>{ts}Content{/ts}</legend>
{strip}
<table class="crm-info-panel">
{if $report.mailing.body_text}
{if array_key_exists('mailing', $report) && $report.mailing.body_text}
<tr>
<td class="label nowrap">{ts}Text Message{/ts}</td>
<td>
Expand All @@ -172,7 +172,7 @@
</tr>
{/if}

{if $report.mailing.attachment}
{if array_key_exists('mailing', $report) && $report.mailing.attachment}
<tr>
<td class="label nowrap">{ts}Attachments{/ts}</td>
<td>
Expand All @@ -193,6 +193,7 @@
{ts}Mailing Settings{/ts}
</legend>
<table class="crm-info-panel">
{if array_key_exists('mailing', $report)}
<tr><td class="label">{ts}Mailing Name{/ts}</td><td>{$report.mailing.name}</td></tr>
{if !$report.mailing.sms_provider_id}
<tr><td class="label">{ts}Subject{/ts}</td><td>{$report.mailing.subject}</td></tr>
Expand All @@ -203,10 +204,11 @@
<tr><td class="label">{ts}Open tracking{/ts}</td><td>{if $report.mailing.open_tracking}{ts}Enabled{/ts}{else}{ts}Disabled{/ts}{/if}</td></tr>
<tr><td class="label">{ts}URL Click-through tracking{/ts}</td><td>{if $report.mailing.url_tracking}{ts}Enabled{/ts}{else}{ts}Disabled{/ts}{/if}</td></tr>
{/if}
{/if}
{if $public_url}
<tr><td class="label">{ts}Public url{/ts}</td><td><a href="{$public_url}"> {$public_url}</a></td></tr>
{/if}
{if $report.mailing.campaign}
{if array_key_exists('mailing', $report) && $report.mailing.campaign}
<tr><td class="label">{ts}Campaign{/ts}</td><td>{$report.mailing.campaign}</td></tr>
{/if}
</table>
Expand Down