Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice fixes for when mailing key does not exist #31640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eileenmcnaughton
Copy link
Contributor

These were picked up from the civi log but would relate to the different statuses the mailing might have

These were picked up from the civi log but would relate to the different statuses the
mailing might have
Copy link

civibot bot commented Dec 20, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Dec 20, 2024
@demeritcowboy
Copy link
Contributor

Having trouble with this one:
(a) I don't see how these warnings can come up. The whole point of this page is to display report.mailing so it can't really be missing. Even if it's just scheduled but not sent, the var is still there.
(b) You've indicated they're in civi log but typically smarty warnings about missing vars aren't in the log - only if it's a crash.
(c) I do see warnings about $group.mailing, but that's a different var not covered in this PR. Similarly I see one about campaign (since I don't happen to have campaigns where I'm looking).

@eileenmcnaughton
Copy link
Contributor Author

@demeritcowboy - this covers the Campaign one #31654

I guess the notice I was seeing in the logs could be group.mailing not just plain mailing - there is soooo much noise from these smarty notices in the php log it's hard to know - because I seem to be be looking at a backtrace for each one with a lot of scrolling.... I suspect what might be happening is that actually an invalid mailing_id is being hit in the url - so the php log is getting filled with noise - but nothing usable is rendered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants