Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3087/#3099: Quick Content Fixes - [MS] #3244

Merged
merged 5 commits into from
Dec 30, 2024
Merged

#3087/#3099: Quick Content Fixes - [MS] #3244

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e41444f
add errors to domain add user form
Matt-Spence Dec 18, 2024
d84c120
remove duplicate sentence from senior official page
Matt-Spence Dec 18, 2024
1df7a9d
Merge remote-tracking branch 'origin/main' into ms/3087-quick-fixes
Matt-Spence Dec 23, 2024
d51c022
minor additional fix
Matt-Spence Dec 30, 2024
9f3b7d3
Merge branch 'main' into ms/3087-quick-fixes
Matt-Spence Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/registrar/templates/domain_add_user.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@
</nav>
{% endif %}
{% endblock breadcrumb %}

{% include "includes/form_errors.html" with form=form %}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read on the ticket that the error is supposed to appear on the field level and at the top of the page. Was there an update that wasn't noted? I don't get the error at the top

Screenshot 2024-12-23 at 10 24 24 AM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't deployed to MS at the time you did the review, sorry. I have two PR's up but forgot that I only have one sandbox 🫠. Should deploy shortly.

<h1>Add a domain manager</h1>
{% if has_organization_feature_flag %}
<p>
Expand Down
1 change: 0 additions & 1 deletion src/registrar/templates/includes/senior_official.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ <h1>Senior official</h1>
</form>
{% elif not form.full_name.value and not form.title.value and not form.email.value %}
<p>
Your senior official is a person within your organization who can authorize domain requests.
We don't have information about your organization's senior official. To suggest an update, email <a href="mailto:[email protected]" class="usa-link">[email protected]</a>.
</p>
{% else %}
Expand Down
Loading