-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3087/#3099: Quick Content Fixes - [MS] #3244
Conversation
🥳 Successfully deployed to developer sandbox ms. |
@@ -37,6 +37,9 @@ | |||
</nav> | |||
{% endif %} | |||
{% endblock breadcrumb %} | |||
|
|||
{% include "includes/form_errors.html" with form=form %} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wasn't deployed to MS at the time you did the review, sorry. I have two PR's up but forgot that I only have one sandbox 🫠. Should deploy shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🥳 Successfully deployed to developer sandbox ms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of things I noticed:
-
Multiple success messages: There's two success alerts after I correct an erroneous zip code in the Organization page (org model). Noticed that same thing happens for other fields as well on the page.
-
Placement of page error alert:
Usually page errors are placed above the heading like so:
However, the page error alerts (for all fields) on the Organization page are below the heading, under the instructional paragraph. Was this intentional? Can we move them above so that they're more consistent?
🥳 Successfully deployed to developer sandbox ms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the additional fix!
🥳 Successfully deployed to developer sandbox ms. |
Ticket
Resolves #3087
Resolves #3099
Changes
Context for reviewers
Setup
Code Review Verification Steps
Put in an invalid email address when adding a domain manager -> check that the correct error message displays (including at the top of the page and on the input itself)
View senior officials in org and non-org mode for domains that don't have senior officials listed. Check that duplicate sentences have been removed.
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Validated user-facing changes as a developer
Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
References
Screenshots