#2976: Senior Official and federal agency field changes for non federal agencies - [BACKUP]

[zandercymatics]

Ticket

Resolves #2976

Changes

On the portfolio page:

• Senior official is now editable for non-federal agencies
• "Federal agency" is now hidden when non-federal
• Some cleanup logic for swapping between states (cleaning senior official, setting to non-federal agency)

Context for reviewers

NOTE: This PR only changes the portfolio page.

This PR does three things on the Portfolio page in django admin:

• Makes senior official editable for non federal portfolios
• Senior officials are cleared when not federal. Federal portfolios still auto populate SO based on federal agency.
• When the organization type is changed to non federal, the federal agency field gets set to "Non-Federal Agency" and the senior official is cleaned up

if organization type changes to any non federal options (on save), the federal agency should be cleared, set to non-federal agency,and hidden. When this federal agency clears the SO for that federal agency should no longer show up

Setup

Navigate to the portfolio page in django admin and swap between the organization type federal and not federal. Ensure that the three things outlined above occur.

The steps to do so are as follows (and what to look for):

1. Login to /admin as a superuser
2. Navigate to the "Portfolios" table
3. Click a portfolio record
4. Change the federal agency field to any value that is NOT non-federal agency
5. Change the "organization type" field from federal => any other value (like city)
6. Note that the federal agency field is now invisible
7. Click save. Note that after save the senior official field is editable now
8. Change the federal agency back to federal, click save
9. Note that the federal agency has been changed back to non-federal agency (should reappear) and the field is now not editable again
10. Repeat these steps while logged in as an analyst

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

• Met the acceptance criteria, or will meet them in a subsequent PR
• Created/modified automated tests
• Update documentation in READMEs and/or onboarding guide

Ensured code standards are met (Original Developer)

• If any updated dependencies on Pipfile, also update dependencies in requirements.txt.
• Interactions with external systems are wrapped in try/except
• Error handling exists for unusual or missing values

Validated user-facing changes (if applicable)

• Tag @dotgov-designers in this PR's Reviewers for design review. If code is not user-facing, delete design reviewer checklist
• Verify new pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
• Checked keyboard navigability
• Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

• Pulled this branch locally and tested it
• Verified code meets all checks above. Address any checks that are not satisfied
• Reviewed this code and left comments. Indicate if comments must be addressed before code is merged
• Checked that all code is adequately covered by tests
• Verify migrations are valid and do not conflict with existing migrations

Validated user-facing changes as a developer

Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.

• New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
• Checked keyboard navigability
• Meets all designs and user flows provided by design/product
• Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
• (Rarely needed) Tested as both an analyst and applicant user

As a designer reviewer, I have

Verified that the changes match the design intention

• Checked that the design translated visually
• Checked behavior. Comment any found issues or broken flows.
• Checked different states (empty, one, some, error)
• Checked for landmarks, page heading structure, and links

Validated user-facing changes as a designer

• Checked keyboard navigability
• Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
• Tested with multiple browsers (check off which ones were used)
  • Chrome
  • Microsoft Edge
  • FireFox
  • Safari
• (Rarely needed) Tested as both an analyst and applicant user

References

• Code review best practices

Screenshots

[github-actions]

🥳 Successfully deployed to developer sandbox za.

[github-actions]

🥳 Successfully deployed to developer sandbox za.

[github-actions]

🥳 Successfully deployed to developer sandbox za.

[asaki222]

LGTM! I Like the descriptions.

[github-actions]

🥳 Successfully deployed to developer sandbox za.