-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pre-commit issues. #33
Merged
cduhn17
merged 3 commits into
develop
from
30-pre-commit-prevents-commits-due-to-ansible-lint-and-packer-lint-hooks
Mar 12, 2024
Merged
Fix pre-commit issues. #33
cduhn17
merged 3 commits into
develop
from
30-pre-commit-prevents-commits-due-to-ansible-lint-and-packer-lint-hooks
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matthew-Grayson
requested review from
aloftus23,
cduhn17,
nickviola,
rapidray12 and
schmelz21
as code owners
March 8, 2024 20:35
nickviola
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ameliav
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Matthew-Grayson
changed the title
Comment out pre-commit hooks for Packer and Ansible with justification.
Fix pre-commit issues.
Mar 11, 2024
aloftus23
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
rapidray12
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Add exclude_paths to .ansible-lint for dependency files.
💭 Motivation and context
Closes issue #30
Per Fusion's request, I reverted the commented out hooks.
The exclude_paths values mean ansible-lint skips dependency files.
The packer_validate hook failure was solved locally by installing Packer. This is already a step in the startup script found in the cisagov development guide. It's an easy step to miss, especially for non-agency contributors.
🧪 Testing
Running
precommit run --all-files
passes for packer and ansible hooks.✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist