Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-commit issues. #33

Conversation

Matthew-Grayson
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson commented Mar 8, 2024

🗣 Description

Add exclude_paths to .ansible-lint for dependency files.

💭 Motivation and context

Closes issue #30
Per Fusion's request, I reverted the commented out hooks.
The exclude_paths values mean ansible-lint skips dependency files.
The packer_validate hook failure was solved locally by installing Packer. This is already a step in the startup script found in the cisagov development guide. It's an easy step to miss, especially for non-agency contributors.

🧪 Testing

Running precommit run --all-files passes for packer and ansible hooks.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ameliav ameliav self-requested a review March 11, 2024 15:44
Copy link
Contributor

@ameliav ameliav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Matthew-Grayson Matthew-Grayson changed the title Comment out pre-commit hooks for Packer and Ansible with justification. Fix pre-commit issues. Mar 11, 2024
Copy link
Contributor

@aloftus23 aloftus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@cduhn17 cduhn17 merged commit 3eb4208 into develop Mar 12, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pre-commit Prevents Local Commits Due to ansible-lint and packer-lint Hooks
6 participants