Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit Prevents Local Commits Due to ansible-lint and packer-lint Hooks #30

Closed
Matthew-Grayson opened this issue Mar 8, 2024 · 0 comments · Fixed by #33
Closed

pre-commit Prevents Local Commits Due to ansible-lint and packer-lint Hooks #30

Matthew-Grayson opened this issue Mar 8, 2024 · 0 comments · Fixed by #33
Assignees
@Matthew-Grayson

Comments

@Matthew-Grayson
Copy link
Contributor

Matthew-Grayson commented Mar 8, 2024 •
edited
Loading

🐛 Summary

The ansible-lint hook takes several minutes to complete and it returns lint errors from checking hundreds of thousands of files we don't version control, such as those found in node packages. The packer-lint hook fails even though we don't have packer files.
Files aren't committed when there is a failure.
Screenshot 2024-03-08 at 08 31 55
@Matthew-Grayson Matthew-Grayson changed the title pre-commit Freezes when Running ansible-lint Hook pre-commit Prevents Commits Due to ansible-lint and packer-lint Hooks Mar 8, 2024
@Matthew-Grayson Matthew-Grayson self-assigned this Mar 8, 2024
@Matthew-Grayson Matthew-Grayson linked a pull request Mar 8, 2024 that will close this issue
Fix pre-commit issues. #33
Merged
12 tasks
@Matthew-Grayson Matthew-Grayson mentioned this issue Mar 8, 2024
Merged
12 tasks
@Matthew-Grayson Matthew-Grayson changed the title pre-commit Prevents Commits Due to ansible-lint and packer-lint Hooks pre-commit Prevents Local Commits Due to ansible-lint and packer-lint Hooks Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Matthew-Grayson Matthew-Grayson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pre-commit issues. cisagov/XFD
1 participant
@Matthew-Grayson