-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterize and Update CORS and CSP #244
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from policies; refactor csp to allow embeding DHS NTAS widget.
…p.ts since it only applies to local environment.
Closed
Matthew-Grayson
requested review from
aloftus23,
cduhn17,
nickviola,
rapidray12 and
schmelz21
as code owners
May 10, 2024 19:47
cduhn17
reviewed
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per conversation. Do we want to parameterize some of these URL's so we dont have to go through a review and release cycle in the event the URL do change.
10 tasks
Per @cduhn17's suggestion, I'll parameterize these settings |
…nt variable for policies to dev.env.example for local development.
Matthew-Grayson
changed the title
241 add explicit cors urls
Parameterize and Update CORS and CSP
May 20, 2024
aloftus23
approved these changes
May 23, 2024
rapidray12
approved these changes
May 23, 2024
Needed for ANDI to run correctly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Update CORS and CSP
Convert CORS and CSP settings to environment variables.
Add variables to dev.env.example for local testing
Delete constants.js file
💭 Motivation and context
Updated CORS and CSP improve site security limiting which websites can request resources from our API. This reduces the risk of cross-site request forgery (CSRF) and data leakage, as only listed origins are allowed to interact with our server.
Parameterizing these settings allows us to change them using the AWS console without initiating a new deployment.
closes issue #241
🧪 Testing
All tests pass and site functions as expected. Full testing requires deployment to DMZ staging.
You must add the following new environment variables from dev.env.example to your .env file for your local environment to work.
✅ Pre-approval checklist
in code comments.
✅ Pre-merge checklist
✅ Post-merge checklist