Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update content security policy to display NTAS iframe #243

Closed
wants to merge 2 commits into from
Closed

Update content security policy to display NTAS iframe #243

wants to merge 2 commits into from

Conversation

chrtorres
Copy link
Collaborator

@chrtorres chrtorres commented May 10, 2024 •
edited
Loading

🗣 Description

💭 Motivation and context

Within the ReadySetCyber Dashboard footer, an Iframe has been added to display the National Terrorism Advisory System (NTAS) widget. This widget is displayed within a local environment, but once in staging it is prevented from loading by the content security policy.

This closes issue #242

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@chrtorres chrtorres self-assigned this May 10, 2024
@chrtorres chrtorres linked an issue May 10, 2024 that may be closed by this pull request
Update Content Security Policy for ReadySetCyber Dashboard #242
Closed
@chrtorres chrtorres marked this pull request as ready for review May 10, 2024 18:04
cduhn17
cduhn17 approved these changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrtorres
Copy link
Collaborator Author

Closing this Pull request, covered in detail by @Matthew-Grayson on PR #244

@chrtorres chrtorres closed this May 13, 2024
@chrtorres chrtorres deleted the rsc-update-security-policy branch May 13, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cduhn17 cduhn17 cduhn17 approved these changes

@aloftus23 aloftus23 Awaiting requested review from aloftus23 aloftus23 is a code owner

@Matthew-Grayson Matthew-Grayson Awaiting requested review from Matthew-Grayson Matthew-Grayson is a code owner

@nickviola nickviola Awaiting requested review from nickviola nickviola is a code owner

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 is a code owner

@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 is a code owner

Assignees

@chrtorres chrtorres

Labels
backend frontend readysetcyber
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Content Security Policy for ReadySetCyber Dashboard
2 participants
@chrtorres @cduhn17