Update RSC Dashboard Navigation #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new DefaultSideNav component to dashboard. Added mapped categories to side nav with links to each category. Installed hash-link package to handle scrolling to anchor tags.
- Made SideNav sticky. - Added ScrollTop component to handle scrolling to top of Detail page. - Added scroll to top button to Detail component. - Made Header fixed.
- Added RSCAccordionNav.tsx to handle category navigation in the mobile view - Added anchor tags to the RSCDetail.tsx to handle the navigation to the different sections of the page - Removed side nav in mobile. - Relocated basic nav options to drop down menu in the mobile view. - Added scroll to top button in the mobile view. - Made side nav sticky in the desktop view. - Cleaned up code. Removed unused imports and variables.
Cleaned up code. Removed unnecessary imports and divs.
- Header and side nav are positioned relative and now scroll with the page. - Added a FAB to trigger a pop up nav menu to allow users to move quickly between sections once side nav is out of view. - Cleaned up code.
- Refactored component to autoclose after selection. - Built new hash link to navigate to anchor tags.
2 tasks
schmelz21
approved these changes
Apr 23, 2024
- removed JSX fragment from FloatingNav.tsx - added a new div to wrap the JSX in FloatingNav.tsx - removed unnecessary console.log from RSCDetail.tsx
hawkishpolicy
requested review from
aloftus23,
cduhn17,
Matthew-Grayson,
nickviola and
rapidray12
as code owners
cisagovbot
pushed a commit
that referenced
this pull request
Sep 25, 2024
Switch the `pre-commit` hook used to run `prettier`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored navigation components in desktop and mobile views
🗣 Description
💭 Motivation and context
Provides improved navigation of site for desktop and mobile users
closes #170
🧪 Testing
📷 Screenshots (if appropriate)
Uncomment this section if a screenshot is needed.
✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist