Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RSC Side Nav hash-links #209

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Fix RSC Side Nav hash-links #209

merged 1 commit into from
Apr 30, 2024

Conversation

chrtorres
Copy link
Collaborator

@chrtorres chrtorres commented Apr 29, 2024

🗣 Description

This pull request aims to fix the react-hash-link implementation within the side navigation and floating navigation components of ReadySetCyber Dashboard.

💭 Motivation and context

Anchor tags are linked to navigation items via react-hash-link. These navigation items should be clickable anywhere within the menu item. Prior to this fix, a user would only activate a click event by clicking directly on the text. This update would make the entire menu item a clickable event.

This issue is linked to pull request #186 and issue #170

📷 Screenshots

Screenshot 2024-04-29 at 4 29 38 PM

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@chrtorres chrtorres self-assigned this Apr 29, 2024
@chrtorres chrtorres added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use frontend readysetcyber labels Apr 29, 2024
@chrtorres chrtorres marked this pull request as ready for review April 29, 2024 20:34
Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aloftus23 aloftus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nickviola nickviola merged commit 9398d85 into develop Apr 30, 2024
14 of 15 checks passed
@nickviola nickviola deleted the rsc-fix-sidenav-hashlink branch April 30, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend improvement This issue or pull request will add or improve functionality, maintainability, or ease of use readysetcyber
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants