Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amended backend/dockerfile to fix node-gyp error during npm start on Apple Silicon powered Macs #109

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Amended backend/dockerfile to fix node-gyp error during npm start on Apple Silicon powered Macs #109

merged 2 commits into from
Apr 22, 2024

Conversation

hawkishpolicy
Copy link
Collaborator

🗣 Description

Amended backend/Dockerfile to fix node-gyp error on Apple Silicon powered Macs.

💭 Motivation and context

Fixes node-gyp error during docker-build.

Closes issue #84

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@hawkishpolicy hawkishpolicy added bug This issue or pull request addresses broken functionality docker Pull requests that update Docker code labels Mar 19, 2024
@hawkishpolicy hawkishpolicy self-assigned this Mar 19, 2024
@hawkishpolicy hawkishpolicy linked an issue Mar 19, 2024 that may be closed by this pull request
NPM start fails on M1+ (Apple Silicon) powered Macs #84
Closed
@hawkishpolicy hawkishpolicy marked this pull request as ready for review March 20, 2024 19:28
@hawkishpolicy hawkishpolicy mentioned this pull request Apr 19, 2024
Closed
12 tasks
cduhn17
cduhn17 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmelz21 schmelz21 merged commit 82bb263 into develop Apr 22, 2024
13 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matthew-Grayson Matthew-Grayson Matthew-Grayson approved these changes

@cduhn17 cduhn17 cduhn17 approved these changes

@aloftus23 aloftus23 Awaiting requested review from aloftus23 aloftus23 is a code owner

@nickviola nickviola Awaiting requested review from nickviola nickviola is a code owner

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 is a code owner

@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 is a code owner

Assignees

@hawkishpolicy hawkishpolicy

Labels
bug This issue or pull request addresses broken functionality docker Pull requests that update Docker code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPM start fails on M1+ (Apple Silicon) powered Macs
4 participants
@hawkishpolicy @cduhn17 @Matthew-Grayson @schmelz21