Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM start fails on M1+ (Apple Silicon Macs) #85

Closed
wants to merge 1 commit into from
Closed

NPM start fails on M1+ (Apple Silicon Macs) #85

wants to merge 1 commit into from

Conversation

hawkishpolicy
Copy link
Collaborator

@hawkishpolicy hawkishpolicy commented Mar 15, 2024

🗣 Description

Amended backend/Dockerfile to fix node-gyp error on Apple Silicon powered Macs.

💭 Motivation and context

Fixes node-gyp error during docker-build.

Closes issue #84

🧪 Testing

Added the additional apk commands.
Re-ran NPM start
App is now up on local host!

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@hawkishpolicy hawkishpolicy added bug This issue or pull request addresses broken functionality docker Pull requests that update Docker code labels Mar 15, 2024
@hawkishpolicy hawkishpolicy self-assigned this Mar 15, 2024
@hawkishpolicy hawkishpolicy changed the title NPM start fails on M1+ (Apple Silicone) powered Macs #84 NPM start fails on M1+ (Apple Silicone powered Macs #84 Mar 15, 2024
@hawkishpolicy hawkishpolicy marked this pull request as ready for review March 15, 2024 19:17
@Matthew-Grayson Matthew-Grayson changed the title NPM start fails on M1+ (Apple Silicone powered Macs #84 NPM start fails on M1+ (Apple Silicon Macs) Mar 18, 2024
@Matthew-Grayson
Copy link
Contributor

Would you please create a branch in XFD and make a new PR from that branch? Using a forked branch adds just a little more friction to the review process.

@hawkishpolicy
Copy link
Collaborator Author

hawkishpolicy commented Mar 19, 2024 via email

@hawkishpolicy
Copy link
Collaborator Author

Closing this because it is duplicated on PR #109.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants