Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state selection and regional admin option to form in Users.tsx #107

Merged

Conversation

ameliav
Copy link
Contributor

@ameliav ameliav commented Mar 19, 2024

🗣 Description

Add state selection and regional admin option to add new user form

💭 Motivation and context

Improves user experience. Allows a user to add a single regional admin from the user interface and requires a state to be selected per each new user.

🧪 Testing

New changes should be reflected and allow a new user to receive an email

📷 Screenshots (if appropriate)

Updated form
image

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@ameliav ameliav self-assigned this Mar 19, 2024
@ameliav ameliav linked an issue Mar 19, 2024 that may be closed by this pull request
@ameliav ameliav marked this pull request as ready for review March 19, 2024 20:24
Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested and worked as expected locally.

Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@schmelz21 schmelz21 merged commit e5d7dbe into develop Mar 19, 2024
9 of 14 checks passed
@ameliav ameliav deleted the 103-ui-add-regional-admin-to-create-new-user-form branch March 20, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Add Regional Admin and State selection to Create New User Form
3 participants