Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic example of approbation test #59

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tyrcho
Copy link

@tyrcho tyrcho commented Jun 29, 2020

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2020

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   80.00%   80.00%           
=======================================
  Files           6        6           
  Lines         105      105           
=======================================
  Hits           84       84           
  Misses         21       21           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f2c1cc...6c65f09. Read the comment docs.

@tyrcho
Copy link
Author

tyrcho commented Jun 29, 2020

@travisbrown I think this will require a small change in my approval library so you can access easily the approved file, I'll try to publish this soon.

@tyrcho
Copy link
Author

tyrcho commented Jun 30, 2020

@travisbrown I finished the example to show you how approvals-scala can be used. I'm not strong enough with circe to go further, but I think you get the idea. What do you think ?

@travisbrown
Copy link
Member

@tyrcho Thanks! I'll take a closer look tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants