Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golden logic outside of the lib #53

Open
tyrcho opened this issue Jun 6, 2020 · 2 comments
Open

golden logic outside of the lib #53

tyrcho opened this issue Jun 6, 2020 · 2 comments

Comments

@tyrcho
Copy link

tyrcho commented Jun 6, 2020

Hi,

Great idea with this lib ! I'm not using it yet but I will recommend it to my team.

I saw in the README that you are concerned with the fragility of writing the golden files. You might want to delegate this to another library.

I maintain https://gitlab.com/tyrcho/approvals-scala and I'd be happy to help with the integration.

Here is a sample project demonstrating a possible integration : https://github.com/WriteThemFirst/approvals-demo-scala

@travisbrown
Copy link
Member

Hi! Sorry for the long delay in responding, but yes, I'd definitely be interested in using a library like approvals-scala for that part.

@tyrcho
Copy link
Author

tyrcho commented Jun 29, 2020

will be easier with a PR : #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants