Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comment #2

Open
wants to merge 35 commits into
base: auto-pr-comment-issue-824
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
956fff3
Use temp .netrc file for integration tests
chuckwondo Sep 16, 2024
e6f45d9
Suppress pip warning about running as root user
chuckwondo Sep 22, 2024
b461a4e
Check permission only for pull_request_target event
chuckwondo Sep 22, 2024
f512721
Remove unnecessary dup env vars
chuckwondo Sep 22, 2024
ef42ea7
Move project urls to correct section of pyproject.toml
chuckwondo Sep 22, 2024
3ba2d30
Correct Luis's email address
chuckwondo Sep 22, 2024
c11aae1
Move and complete kerchunk dependencies
chuckwondo Sep 22, 2024
16e1982
Add missing type annotation
chuckwondo Sep 22, 2024
82fd120
Include kerchunk extra within test extra
chuckwondo Sep 22, 2024
3588e87
Add nox integration-tests session
chuckwondo Sep 22, 2024
55db17b
Mindeps requires python 3.9, h5py 3.0+
chuckwondo Sep 23, 2024
86b1399
Remove noise from CHANGELOG
chuckwondo Sep 23, 2024
8f6c6dc
Update uv.lock
chuckwondo Sep 23, 2024
b97c9db
Fix type hint for threads parameter
chuckwondo Sep 24, 2024
52aa3bb
Remove top-level assertions
chuckwondo Sep 24, 2024
9a8598d
Specify explicit engine
chuckwondo Sep 24, 2024
031ded7
Remove obsolete on-prem DAAC entry for ORNLDAAC
chuckwondo Sep 26, 2024
9321919
Fix CHANGELOG to match Common Changelog convention
chuckwondo Sep 26, 2024
9a2cfd5
Experiment
chuckwondo Sep 27, 2024
60cd60e
experiment
chuckwondo Sep 27, 2024
f0e4668
experiment
chuckwondo Sep 27, 2024
42265c1
experiment
chuckwondo Sep 27, 2024
fc200b9
experiment
chuckwondo Sep 27, 2024
2ea78d8
experiment
chuckwondo Sep 27, 2024
a3b963d
experiment
chuckwondo Sep 27, 2024
50a68f0
experiment
chuckwondo Sep 27, 2024
74bd9c9
experiment
chuckwondo Sep 27, 2024
6f05df1
experiment
chuckwondo Sep 27, 2024
cbcc16c
experiment
chuckwondo Sep 27, 2024
f05de5a
experiment
chuckwondo Sep 27, 2024
dcbc82a
experiment
chuckwondo Sep 27, 2024
4da939f
experiment
chuckwondo Sep 27, 2024
3a2f08d
experiment
chuckwondo Sep 27, 2024
ff3457a
remove exit
chuckwondo Sep 27, 2024
9b447b3
Oops! Added back mistakenly removed line.
chuckwondo Sep 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Check permission only for pull_request_target event
chuckwondo committed Sep 26, 2024
commit b461a4ea36d7efc98c994d6da7b8a1bd0f925d1d
7 changes: 6 additions & 1 deletion .github/workflows/integration-test.yml
Original file line number Diff line number Diff line change
@@ -47,14 +47,19 @@ jobs:

steps:
- name: Fetch user permission
if: github.event_name == 'pull_request_target'
id: permission
uses: actions-cool/check-user-permission@v2
with:
require: write
username: ${{ github.triggering_actor }}

- name: Check user permission
if: ${{ steps.permission.outputs.require-result == 'false' }}
# The name of the output require-result is a bit confusing, but when its value
# is 'false', it means that the triggering actor does NOT have the required
# permission.
if: github.event_name == 'pull_request_target' && steps.permission.outputs.require-result == 'false'

# If the triggering actor does not have write permission (i.e., this is a
# PR from a fork), then we exit, otherwise most of the integration tests will
# fail because they require access to secrets. In this case, a maintainer