Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comment #2

Open
wants to merge 35 commits into
base: auto-pr-comment-issue-824
Choose a base branch
from

Conversation

chuckwondojo
Copy link

@chuckwondojo chuckwondojo commented Sep 27, 2024

Pull Request (PR) draft checklist - click to expand
  • Please review our
    contributing documentation
    before getting started.
  • Ensure an issue exists representing the problem being solved in this PR.
  • Populate a descriptive title. For example, instead of "Updated README.md", use a
    title such as "Add testing details to the contributor section of the README".
    Example PRs: #763
  • Populate the body of the pull request with:
  • Update CHANGELOG.md with details about your change in a section titled
    ## Unreleased. If such a section does not exist, please create one. Follow
    Common Changelog for your additions.
    Example PRs: #763
  • Update the documentation and/or the README.md with details of changes to the
    earthaccess interface, if any. Consider new environment variables, function names,
    decorators, etc.

Click the "Ready for review" button at the bottom of the "Conversation" tab in GitHub
once these requirements are fulfilled. Don't worry if you see any test failures in
GitHub at this point!

Pull Request (PR) merge checklist - click to expand

Please do your best to complete these requirements! If you need help with any of these
requirements, you can ping the @nsidc/earthaccess-support team in a comment and we
will help you out!

  • Add unit tests for any new features.
  • Apply formatting and linting autofixes. You can add a GitHub comment in this Pull
    Request containing "pre-commit.ci autofix" to automate this.
  • Ensure all automated PR checks (seen at the bottom of the "conversation" tab) pass.
  • Get at least one approving review.

📚 Documentation preview 📚: https://earthaccess--2.org.readthedocs.build/en/2/

@chuckwondojo chuckwondojo force-pushed the auto-pr-comment-experiment branch 4 times, most recently from 8e22f11 to 1c589cd Compare September 27, 2024 18:52
@chuckwondojo chuckwondojo force-pushed the auto-pr-comment-experiment branch from 1c589cd to 60cd60e Compare September 27, 2024 19:02
@chuckwondo chuckwondo reopened this Sep 27, 2024
@chuckwondojo chuckwondojo force-pushed the auto-pr-comment-experiment branch from ab78b00 to a816c66 Compare September 27, 2024 20:07
@chuckwondojo chuckwondojo force-pushed the auto-pr-comment-experiment branch from b626b77 to 7ab28f4 Compare September 27, 2024 21:03
@chuckwondojo chuckwondojo force-pushed the auto-pr-comment-experiment branch from 7ab28f4 to 971aad1 Compare September 27, 2024 21:30
@chuckwondojo chuckwondojo force-pushed the auto-pr-comment-experiment branch from 971aad1 to b9e7fdd Compare September 27, 2024 21:40
@chuckwondojo chuckwondojo force-pushed the auto-pr-comment-experiment branch from b9e7fdd to 0f6b2fa Compare September 27, 2024 21:42
@chuckwondojo chuckwondojo force-pushed the auto-pr-comment-experiment branch from 0f6b2fa to b5e560e Compare September 27, 2024 22:07
@chuckwondojo chuckwondojo force-pushed the auto-pr-comment-experiment branch from b5e560e to e3da19a Compare September 27, 2024 22:11
Copy link

Hello world!

@chuckwondojo chuckwondojo force-pushed the auto-pr-comment-experiment branch from e3da19a to dd9a586 Compare September 27, 2024 22:34
Copy link

User chuckwondojo does not have permission to to run integration tests. A maintainer must perform a security review and re-run the failed jobs, if the code is deemed safe.

@chuckwondojo chuckwondojo force-pushed the auto-pr-comment-experiment branch from dd9a586 to 8680ae7 Compare September 27, 2024 23:04
Copy link

User chuckwondojo does not have permission to run integration tests. A maintainer must perform a security review of the code changes in this pull request and re-run the failed integration tests jobs, if the code is deemed safe.

Copy link
Owner

@chuckwondo chuckwondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work without the line that was removed.

Copy link

User chuckwondojo does not have permission to run integration tests. A maintainer must perform a security review of the code changes in this pull request and re-run the failed integration tests jobs, if the code is deemed safe.

@chuckwondo chuckwondo self-requested a review September 27, 2024 23:24
@chuckwondojo chuckwondojo force-pushed the auto-pr-comment-experiment branch from b1dae63 to 9b447b3 Compare September 27, 2024 23:33
Copy link

User chuckwondojo does not have permission to run integration tests. A maintainer must perform a security review of the code changes in this pull request and re-run the failed integration tests jobs, if the code is deemed safe.

@chuckwondo chuckwondo force-pushed the auto-pr-comment-issue-824 branch 2 times, most recently from 2cd21a8 to 3ffbe2a Compare October 6, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants