Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to interface with gcp and external-cloud-provider #15

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

addyess
Copy link
Member

@addyess addyess commented Mar 5, 2024

Removed google cloud external interface warnings, and improved unit tests

"GCP cloud-provider is currently available in-tree "
"but can be avoided configuring here if we use the "
"external tree provider"
)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

with open("/root/cdk/kubelet/config.yaml", "w") as f:
p = Path("/root/cdk/kubelet/config.yaml")
p.parent.mkdir(parents=True, exist_ok=True)
with p.open("w") as f:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@kwmonroe kwmonroe merged commit 3a5e868 into main Mar 6, 2024
6 checks passed
@kwmonroe kwmonroe deleted the KU-439/gcp-cloud-integration branch March 6, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants