Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrate with google cloud gcp relation and external-cloud-provider #339

Merged
merged 2 commits into from
Mar 7, 2024
Merged

integrate with google cloud gcp relation and external-cloud-provider #339

merged 2 commits into from
Mar 7, 2024

Conversation

addyess
Copy link
Member

@addyess addyess commented Mar 5, 2024

Tests integration with Google Cloud and external provider

  • gcp-cloud-provider
  • gcp-k8s-storage
  • gcp-integrator charms through the ops version of the gcp-integration

Depends on merges of:

kwmonroe
kwmonroe approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@kwmonroe kwmonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested an update to the requirements branches given the preerqs are merged; given that, lgtm.

requirements.txt Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
src/cloud_integration.py Show resolved Hide resolved
@addyess addyess marked this pull request as ready for review March 7, 2024 03:29
@kwmonroe kwmonroe merged commit 365df7d into main Mar 7, 2024
7 checks passed
@kwmonroe kwmonroe deleted the KU-439/gcp-cloud-integration branch March 7, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwmonroe kwmonroe kwmonroe approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addyess @kwmonroe