Skip to content

Commit

Permalink
feat: remove peer relation and improve integration tests
Browse files Browse the repository at this point in the history
  • Loading branch information
jedel1043 committed Dec 18, 2024
1 parent 9b650d9 commit 5b7fdca
Show file tree
Hide file tree
Showing 13 changed files with 502 additions and 515 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:
with:
version: 0.5.8
- name: Run tests
run: just type
run: just typecheck

integration-test:
name: Integration tests (LXD)
Expand Down
41 changes: 19 additions & 22 deletions charmcraft.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,38 +33,35 @@ parts:
subordinate: true

peers:
storage-peers:
interface: storage_peers

requires:
fs-share:
interface: fs_share
filesystem:
interface: filesystem_info
juju-info:
interface: juju-info
scope: container

config:
options:
mountinfo:
mounts:
default: "{}"
type: string
description: |
Information to mount the filesystem on the machine. This is specified as a JSON object string.
Information to mount filesystems on the machine. This is specified as a JSON object string.
Example usage:
```bash
$ juju config slurmd mountpoints=<<EOF
{
"cephfs": {
"mountpoint": "/scratch",
"noexec": true
},
"nfs": {
"mountpoint": "/data",
"nosuid": true,
"nodev": true,
"read-only": true,
}
}
EOF
$ juju config filesystem-client \
mounts=<<EOF
{
"cephfs": {
"mountpoint": "/scratch",
"noexec": true
},
"nfs": {
"mountpoint": "/data",
"nosuid": true,
"nodev": true,
"read-only": true,
}
}
EOF
```
2 changes: 1 addition & 1 deletion justfile
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ lint: lock
{{uv_run}} ruff format --check --diff {{all}}

# Run static type checks
type *args: lock
typecheck *args: lock
{{uv_run}} pyright {{args}}

# Run unit tests
Expand Down
Loading

0 comments on commit 5b7fdca

Please sign in to comment.