-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geopandas OGC API Features (OAF) Support (USGS/WMA - 33) #9
Conversation
Appears that the sitemap generator is broken. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good!
Some small changes. Can you also use consistent quoting in your python files, I prefer single quotes. You will also need to do some formatting to pass flake8 tests.
Sounds good. Working on changes. By the way, what is your opinion on an autoformatter pre-commit for this repo? Wasn't sure if you want to keep this the same as the pygeoapi style. I honestly don't think about quote style or import order much since I usually just delegate that to ruff. But obviously happy to change things however you prefer. |
Why don't you add precommit here as well then? Fine by me |
Note: I tested this all inside the current pygeoapi master inside a devcontainer docker volume. So I have not tested this in the CI pipeline for this repo yet. Will iterate if there are failures.
Only thing I am currently unsure on:
read_file
don't match the proper datatype. I am not entirely sure how to fix this in a generalized way since the file we are reading in doesn't always specify the type of the data (i.e. CSV) and might require a heuristic, but sometimes the geopandas heuristic is incorrect. The only place this matters isget_fields
since it returns the type associated with the field.