-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit config #11
Conversation
Not really clear what is going wrong here. Pre-commit is making all the fixes but it can't push to the branch. I can't see any reason for this myself, but @webb-ben do you know if we have anything in place that would be blocking pre-commit from pushing? (Some sort of security policy/branch protection rule I can't see for any reason?) It says to make sure the branch is up to date, but it is. (And just for context, the pre-commit message it supposed to say |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change prettier to single quotes?
Thanks for fixing that. When you get a chance would you mind letting me know how you fixed this? Can't tell from git history |
Fixed the precommit ci? For some reason precommit can't lint workflow files so I made sure all the files in |
Adds a pre-commit config. Done in a separate PR from #9 so we don't mess up the git blame.
This is very similar to the config in the template repo. It essentially just applies ruff on every PR so we have a standard format. If we don't like this or want different styles, we can customize ruff with any of its settings listed as it describes here: https://docs.astral.sh/ruff/settings/#extend