Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numpy2 compatibility fixes #416

Closed
wants to merge 1 commit into from
Closed

Numpy2 compatibility fixes #416

wants to merge 1 commit into from

Conversation

benjeffery
Copy link
Member

Fixes #415

@pep8speaks
Copy link

pep8speaks commented Jul 11, 2024 •
edited
Loading

Hello @benjeffery! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-07-11 11:21:38 UTC

@benjeffery benjeffery force-pushed the numpy2 branch 2 times, most recently from 029269c to 1edf36c Compare July 11, 2024 10:01
@benjeffery
Copy link
Member Author

Getting a failure here on test_roh_mhmm_0pct when running with numpy 2 - could someone more familiar with this check this is an acceptable result?

@benjeffery benjeffery mentioned this pull request Jul 11, 2024
Merged
@alimanfoo
Copy link
Contributor

Hi @benjeffery, sorry I missed this at the time. This is now resolved via #418.

@alimanfoo alimanfoo closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Numpy 2.0 compatibility
3 participants
@benjeffery @pep8speaks @alimanfoo