Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements for numpy 2 #276

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Conversation

hyanwong
Copy link
Member

This won't work until scikit-allel is numpy 2.0 compatible. See cggh/scikit-allel#415

Also note that the tszip docs are linked to the latest not stable version. See tskit-dev/tszip#67 (comment)

This won't work until scikit-allel is numpy 2.0 compatible. See cggh/scikit-allel#415
@hyanwong
Copy link
Member Author

hyanwong commented Jul 11, 2024

There's also something weird going on with the R interface here, although it's all compiling locally for me. Something in the R setup could possibly do with changing. This could require some fiddling.

@benjeffery
Copy link
Member

I've made a start on the scikit-allel, but one of the tests is failing and I don't get why: cggh/scikit-allel#416

@hyanwong
Copy link
Member Author

I pinned to the latest non v2 version of numpy, and it all seems to work, so I think we can just merge this and unpin numpy when scikit-allel is updated.

@jeromekelleher
Copy link
Member

SGTM

@benjeffery benjeffery merged commit 88195b7 into tskit-dev:main Jul 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants