55 - update readme with new files and instructions #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aharjati
requested review from
hkeeler,
guffee23,
lchen-2101 and
nargis-sultani
Coverage reportThe coverage rate went from None of the new lines are part of the tested code. Therefore, there is no coverage data about them. |
hkeeler
requested changes
Sep 27, 2023
hkeeler
reviewed
Sep 27, 2023
Comment on lines
+34
to
42
| python src/validator/main.py 000TESTFIUIDDONOTUSE SBL_Validations_SampleData_GoodFile_03312023.csv | ||
| # else just pass the csv_path as arg | ||
| python src/validator/main.py SBL_Validations_SampleData_GoodFile_03312023.csv | ||
|
|
||
| # Test validating the "bad" file | ||
| python src/validator/main.py 000TESTFIUIDDONOTUSE SBL_Validations_SampleData_BadFile_03312023.csv | ||
| # or | ||
| python src/validator/main.py SBL_Validations_SampleData_BadFile_03312023.csv | ||
| ``` |
There was a problem hiding this comment.
thanks for the heads up.
Co-authored-by: Hans Keeler <[email protected]>
thanks. fixed the typo |
hkeeler
approved these changes
Sep 28, 2023
jcadam14
pushed a commit
that referenced
this pull request
May 3, 2024
closes #55 Update README with updates: - Add phase 1 and phase 2 reference - Add quick notes on new files - Update test instruction with LEI update --------- Co-authored-by: Aldrian Harjati <[email protected]> Co-authored-by: Hans Keeler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #55
Update README with updates: