Task 42, creating tests for SampleData GoodFile and BadFile #56
Conversation
nargis-sultani
requested review from
hkeeler,
guffee23,
aharjati and
lchen-2101
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)src/tests/test_sample_data.py
|
|
I think we're going to use src/validator/sample_data.py only for testing so I think it's probably better to put all of these code in the test file : src/tests/test_sample_data.py |
I agree. Doing it now. |
|
I think we should organize CSV files into a folder and remove unused |
That's what I was thinking of too. I can do that |
src/tests/test_sample_data.py
Outdated
| lei = "000TESTFIUIDDONOTUS1" | ||
| validation_result = validate_phases(self.bad_file_df, lei) | ||
|
|
||
| print(validation_result) |
src/validator/main.py
Outdated
| @@ -26,7 +26,6 @@ def run_validation_on_df(df: pd.DataFrame, lei: str) -> None: | |||
| print("") | |||
| print(df) | |||
| print("") | |||
|
|
|||
| print(validate_phases(df, lei)) | |||
There was a problem hiding this comment.
can you undo this space change?
nargis-sultani
deleted the
features/52_testing_for_good_and_bad_data_files
branch
Closes #52 I misunderstood the requirements first. I thought we had to create tests to make sure the GoodFile had the correct data for each field. I understood the requirements later. --------- Co-authored-by: Nargis Sultani <[email protected]>
Closes #52
I misunderstood the requirements first. I thought we had to create tests to make sure the GoodFile had the correct data for each field. I understood the requirements later.