Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask: Update BEM #8389

Merged
merged 3 commits into from
May 9, 2024
Merged

Ask: Update BEM #8389

merged 3 commits into from
May 9, 2024

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented May 7, 2024

Missed this in #8368

This sets the width of the Ask search input.

Also, some term classes weren't migrated.

Changes

  • Update o-search-bar_input to o-search-bar__input
  • Update term_name, term_definition, and term_link

How to test this PR

  1. Visit ask landing page and see that search input is constrained.

Screenshots

Before:
Screenshot 2024-05-07 at 2 19 30 PM

After:
Screenshot 2024-05-07 at 2 19 38 PM

Before:
Screenshot 2024-05-07 at 3 59 24 PM

After:
Screenshot 2024-05-07 at 3 59 18 PM

@anselmbradford anselmbradford changed the title Update o-search-bar_input to o-search-bar__input Ask: Update BEM May 7, 2024
@anselmbradford
Copy link
Member Author

In the future, o-search-bar__input will probably be removed, but I'll leave this fix for now.

@anselmbradford anselmbradford added this pull request to the merge queue May 9, 2024
Merged via the queue into main with commit 7b164ec May 9, 2024
12 checks passed
@anselmbradford anselmbradford deleted the ans_ask_bem branch May 9, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants