fix: polkadot v1.1.0 client #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wischli
added
the
I3-annoyance
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## polkadot-v1.1.0 #1808 +/- ##
===================================================
+ Coverage 47.94% 48.48% +0.53%
===================================================
Files 168 168
Lines 13474 13325 -149
===================================================
Hits 6460 6460
+ Misses 7014 6865 -149 ☔ View full report in Codecov by Sentry. |
|
Just a couple of questions.
|
For now, it is still used so I would keep it. But its expected to be deprecated sometime this year! |
lemunozm
added a commit
that referenced
this pull request
Apr 15, 2024
* all dependencies set * migrate libs/* * migrate pallet-anchors * migrate pallet-rewards * migrate pallet-liquidity-rewards * migrate pallet-fees pallet-bridge * migrate pallet-keystore * migrate restricted-tokens * migrate restricted-xtokens * migrate block-rewards * migrate-interest-accrual * migrate oracle-feed * migrate oracle-collection * migrate collator-allowlist * migrate transfer-allowlist * migrate crowdloan pallets * migrate permissions * migrate order-book * migrate pallet-swaps * migrate pallet-token-mux * migrate investments * migrate foreign-investments * migrate loans * migrate pool-fees * migrate liquidity-pools-gateway * migrate axelar-gateway-precompile * migrate liquidity-pools-gateway-routers & patch moonbeam deps * use precompile-utils from moonbeam from now * simplify mock initialization * simplify some mocks * migrate ethereum-transaction * simplify minor stuff * disable runtimes by now * migrate pool-system * migrate pool-registry * migrate liquidity-pools * polish patch section * dirty fix for unaccesible Pending storage * minor dependency update * minor extend comment * migrate runtime-common * minor fixes * Revert "dirty fix for unaccesible Pending storage" This reverts commit 975060d. * pointing to the updated pallet-ethereum * fix pool-system compilation with benchmarks * fix serde dependencies * required changes for runtime to work * development runtime failing because of serde * patch all required dependencies to make moonbeam works * fix xcm types * add serde to no_std * minor * migrate altair & centrifuge * minor fixes * support runtime-benchmarking in runtimes * Polkadot v1.1.0: Node required changes (#1789) * make it compile * minor change * prepare changes for modify deprecated code * fix ExportGenesisState and remove unused warnings * update benchmark CLI * remove completelly try-runtime-cli * minor clean * fix try-runtime CI job * Polkadot v1.1.0 Integration Tests (#1776) * legacy-test migration wip * main changes * remove unused dependency * basic stuff migrated * uncomment fudge_env * update fudge * integration-tests: Fix test envs (#1780) * main changes * integration-tests: Fix test envs * runtime: Implement parachains pallets for runtimes * runtime: Enable multilocation convert for CurrencyIdConvert * runtime: Remove extra paras pallets * integration-tests: Update expected balances --------- Co-authored-by: lemunozm <[email protected]> --------- Co-authored-by: Cosmin Damian <[email protected]> * fixed issues compiling with rust 1.78 * fix clippy * taplo Signed-off-by: lemunozm <[email protected]> * reading value from deposit_creating * remove locked from taplo-cli * update scripts * fix docs * fix integration tests * add collator-selection migration * makes try-runtime idempotent checks work * revert fixed point serialization, remove unused Location code * comment TODOs and deprecated until 1.3.0 * fix fixed_point serialization for std * correct features for dev dependency * apply Cosmin NITs * remove comments regarding v1.3.0 * revert benchmarking HostFunction * Polkadot v1.1.0: Account converter changes (#1806) * Modify AccountConverter types * fix some imports * fix: polkadot v1.1.0 client (#1808) * fix: deprecate parachain CLI * chore: cleanup deprecated chain specs * fix: clippy --------- Signed-off-by: lemunozm <[email protected]> Co-authored-by: Cosmin Damian <[email protected]> Co-authored-by: William Freudenberger <[email protected]>
lemunozm
reviewed
Apr 16, 2024
| "charcoal-local" => Ok(Box::new(chain_spec::charcoal_local(para_id))), | ||
| "demo" => Ok(Box::new(chain_spec::demo(para_id))), | ||
| "development" => Ok(Box::new(chain_spec::development(para_id))), | ||
| "development-local" => Ok(Box::new(chain_spec::development_local(para_id))), |
There was a problem hiding this comment.
I think we've broken our development benchmarking with this. We didn't have a CI job for development (I do not remember why), and we didn't notice it.
We should call it development-local or modify check_benchmarks.sh script.
cc @wischli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context: https://github.com/centrifuge/centrifuge-chain/pull/1756/files#r1562566212
parachain-idCLI argument which was a custom addition for a few CLI arguments inherited from Substrate2000for ephemeral chain specsdevelopment,centrifuge-local,altair-local10001para id if not set in CLIcharcoal,algol,centrifuge-dev(basicallycentrifuge-local with 2 more funded accounts) andaltair-dev(basicallyaltair-local` with 2 more funded accounts)Fixes #(issue)
Checklist: