Polkadot v1.1.0 #1756
Polkadot v1.1.0 #1756
Conversation
lemunozm
added
Q7-very-hard
lemunozm
force-pushed
the
polkadot-v1.1.0
branch
from
dc93db7 to
fb19264
Compare
| @@ -270,7 +270,7 @@ pub mod constants { | |||
| pub const TRANSACTION_RECOVERY_ID: u64 = 42; | |||
|
|
|||
| /// The safe XCM version of pallet-xcm, same as on relay chain | |||
| pub const SAFE_XCM_VERSION: u32 = xcm::opaque::v2::VERSION; | |||
| pub const SAFE_XCM_VERSION: u32 = staging_xcm::opaque::v2::VERSION; | |||
There was a problem hiding this comment.
FYI: I think we can switch to v3 by now but that would be out of scope of this PR.
There was a problem hiding this comment.
You're right. We can do after merging this 👍🏻
| cargo run --release --features try-runtime try-runtime \ | ||
| try-runtime \ |
There was a problem hiding this comment.
This will break the try-runtime CI. Since you pinged @gpmayorga already and try-runtime being optional, I am fine with leaving this as is.
There was a problem hiding this comment.
This will break the try-runtime CI?
Mmm... you said that because we're not installing try-runtime binary, right? Probably. I've tested locally but I have the tool 😆
There was a problem hiding this comment.
Can we add this as a tech-debt? In the CI job, I've seen some comment lines regarding this. So, probably, just uncommenting those makes this work.
There was a problem hiding this comment.
Since we are not really utilizing the CI right now, totally fine with this.
|
Thanks @wischli for your deep and detailed review 🙌🏻. Really appreciated |
| @@ -272,7 +282,7 @@ pub type LocationToAccountId<RelayNetwork> = ( | |||
| // Straight up local `AccountId32` origins just alias directly to `AccountId`. | |||
| AccountId32Aliases<RelayNetwork, AccountId>, | |||
| // Generate remote accounts according to polkadot standards | |||
| cfg_primitives::xcm::HashedDescriptionDescribeFamilyAllTerminal<AccountId>, | |||
| HashedDescription<AccountId, DescribeFamily<DescribeAllTerminal>>, | |||
There was a problem hiding this comment.
We had test covering the conversions made beforehand and can ensure that they stay the same, right?
* Modify AccountConverter types * fix some imports
There was a problem hiding this comment.
Soft approving this with the following TODO list
Best before merge
TBD
- Hardcode para id for gateway: Polkadot v1.1.0 #1756 (comment)
- Maybe revert removed
HashedDescriptiontests: Polkadot v1.1.0 #1756 (comment)
Post merge
- Switch to dedicated
try-runtimeCLI: Polkadot v1.1.0 #1756 (comment) - Switch to
v3as safe xcm version: Polkadot v1.1.0 #1756 (comment)
* fix: deprecate parachain CLI * chore: cleanup deprecated chain specs * fix: clippy
|
No worries! And thanks for the wrap-up comment! |
Description
Fixes #1734
Current work done
polkadot-sdkwith version1.1.0.polkadot-sdkdependenciescargo check&cargo testusingruntime-benchmarksfeatureEvaluate this: UsedFixed upgrading to rust-1.78chainbridgedependency from Use latest deps for Polkadot v1.1.0 chainbridge-substrate#15, which should be fixed/evaluatedEvaluate this: I've needed to point toFinally using the moonbeam forkpolkadot-evmdependencies instead of themoonbeam-foundationfork. There seems to be a lot of chaos with moonbeam dependencies. Ensure this is correct.lemunozm). <= We should remove this fork in v1.3.0It seemsIt seems not related to this migration. Having the same message onpallet-ethereumneed itmain. It seems it appears because they never set a VERSION.pallet_collator_selection