Update docker test image name #1644
Conversation
There was a problem hiding this comment.
Thanks for the fix. The latest tage event should not be changed. It should indeed only be built during the release trigger for docker, i.e. when we draft a release. Unfortunately, that pipeline didn't get triggered for the latest v0.10.35 release. AFAICT because of missing GHA tokens.
.github/workflows/build-docker.yml
Outdated
| type=raw,value=latest,enable=${{ github.event_name == 'release' }} | ||
| type=raw,value=latest,enable=true |
There was a problem hiding this comment.
This change should not be merged. The purpose of latest reflects the latest releases. We don't want node operators to run our dev images.
There was a problem hiding this comment.
OK, then I'll revert this and I guess we want to debug the issue of not having the latest tag for the last release.
There was a problem hiding this comment.
There are no release events for our repo it seems:
https://github.com/centrifuge/centrifuge-chain/actions?query=event%3Arelease
Maybe we want to have something like the trigger mentioned here:
on:
release:
types: [published]
There was a problem hiding this comment.
We do have that trigger set up:
centrifuge-chain/.github/workflows/build-docker.yml
Lines 6 to 7 in ccbc3a1
Unfortunately, I don't have capacity to look into this. It should be related to this StackOverflow question/solution: https://stackoverflow.com/questions/69063452/github-actions-on-release-created-workflow-trigger-not-working
cdamian
force-pushed
the
docker-enable-latest-tag
branch
from
fec8b84 to
b4db881
Compare
cdamian
force-pushed
the
docker-enable-latest-tag
branch
from
b4db881 to
0042f79
Compare
Description
Update docker test image name