Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Improve logging and fix successful proxy execution check #1605

Merged
merged 12 commits into from
Dec 13, 2023

Conversation

cdamian
Copy link
Collaborator

@cdamian cdamian commented Sep 6, 2023

No description provided.

@cdamian cdamian changed the title api: Improve logging api: Improve logging and fix successful proxy execution check Dec 8, 2023
@cdamian cdamian force-pushed the centapi-improve-logging branch from bc9043d to 1b3d868 Compare December 8, 2023 19:53
@cdamian
Copy link
Collaborator Author

cdamian commented Dec 11, 2023

Will merge as soon as the latest centrifuge-chain image is fixed - centrifuge/centrifuge-chain#1644 and we can run the integration/testworld tests.

@cdamian cdamian force-pushed the centapi-improve-logging branch from 1b3d868 to de6a08f Compare December 11, 2023 10:55
@cdamian cdamian force-pushed the centapi-improve-logging branch from de6a08f to e8556ae Compare December 11, 2023 11:16
lemunozm
lemunozm previously approved these changes Dec 11, 2023
Copy link

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as my Go knowledge is

centchain/api_test.go Outdated Show resolved Hide resolved
@cdamian cdamian merged commit aa767bf into main Dec 13, 2023
4 checks passed
@cdamian cdamian deleted the centapi-improve-logging branch December 13, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants