Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 💾 emoji to save to the incident timeline #383

Merged
merged 11 commits into from
Jan 29, 2024

Conversation

sylviamclaughlin
Copy link
Contributor

@sylviamclaughlin sylviamclaughlin commented Jan 26, 2024

Summary | Résumé

Added functionality for a message to be added to the detailed incident timeline if you add an emoji reaction of 💾 to the message:

Screenshot 2024-01-26 at 11 13 31 AM

In this case, the "Sorry! Please ignore this" will be added to the message. If you wanted to remove the message from the incident timeline, you will just have to untag the emoji (ie remove the reaction from the message). The messages are arranged in ascending chronological order and the order is preserved chronologically no matter when you flag the messages. The messages are arranged by date/time converted to EST. A sample detailed timeline that has been generated by flagging messages is this:

Screenshot 2024-01-26 at 11 29 09 AM

Things still to do:

  1. When a message is edited after the 💾 emoji has been added to the message, the sre bot does not recognize that a message has been modified and does not update the timeline.
  2. If you delete a message, the timeline is not updated.

@sylviamclaughlin sylviamclaughlin requested a review from a team January 26, 2024 19:17
@sylviamclaughlin sylviamclaughlin self-assigned this Jan 26, 2024
Copy link

github-actions bot commented Jan 26, 2024

GitHub Action status on 8bded6a generated by comment-failure-action

Lint, format and test code

job url
null https://github.com/cds-snc/sre-bot/actions/runs/7672449857/job/20912966044

Build containers CI

No jobs failed 👍

app/commands/incident.py Outdated Show resolved Hide resolved
app/commands/incident.py Outdated Show resolved Hide resolved
app/commands/utils.py Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jan 26, 2024

GitHub Action status on cead0ae generated by comment-failure-action

Lint, format and test code

job url
null https://github.com/cds-snc/sre-bot/actions/runs/7674528226/job/20919249394

Build containers CI

No jobs failed 👍

Copy link

github-actions bot commented Jan 26, 2024

GitHub Action status on d8c5239 generated by comment-failure-action

Lint, format and test code

job url
null https://github.com/cds-snc/sre-bot/actions/runs/7674544433/job/20919300939

Build containers CI

No jobs failed 👍

@sylviamclaughlin sylviamclaughlin merged commit bdcb530 into main Jan 29, 2024
4 checks passed
@sylviamclaughlin sylviamclaughlin deleted the feat/save_chat_to_incident_timeline branch January 29, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants