generated from cds-snc/project-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 💾 emoji to save to the incident timeline #383
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub Action status on 8bded6a generated by comment-failure-action Lint, format and test code
Build containers CINo jobs failed 👍 |
patheard
reviewed
Jan 26, 2024
patheard
reviewed
Jan 26, 2024
patheard
reviewed
Jan 26, 2024
GitHub Action status on cead0ae generated by comment-failure-action Lint, format and test code
Build containers CINo jobs failed 👍 |
GitHub Action status on d8c5239 generated by comment-failure-action Lint, format and test code
Build containers CINo jobs failed 👍 |
patheard
approved these changes
Jan 28, 2024
Co-authored-by: Pat Heard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Added functionality for a message to be added to the detailed incident timeline if you add an emoji reaction of 💾 to the message:
In this case, the "Sorry! Please ignore this" will be added to the message. If you wanted to remove the message from the incident timeline, you will just have to untag the emoji (ie remove the reaction from the message). The messages are arranged in ascending chronological order and the order is preserved chronologically no matter when you flag the messages. The messages are arranged by date/time converted to EST. A sample detailed timeline that has been generated by flagging messages is this:
Things still to do: