Updated recipients.csv to accept both lang #245
Conversation
jzbahrai
commented
Sep 22, 2023
jzbahrai
commented
- EN FR headings are now allowed for sms and email
- Your error message will be in the language of your choice
- Updated tests.
- EN FR headings are now allowed for sms and email - Your error message will be in the language of your choice
jzbahrai
force-pushed
the
task/fix-upload
branch
from
7e201e4 to
8d62ea9
Compare
There was a problem hiding this comment.
Nothing looks wrong per se I just find it hard to understand what a few of the lines are doing where many methods are being chained together. It might be helpful to comment a bit for these.
I am going to move on to admin and try testing the functionality to get a better understanding of how it works.
| @@ -290,13 +345,12 @@ def is_optional_address_column(self, key): | |||
|
|
|||
| @property | |||
| def has_recipient_columns(self): | |||
| return ( | |||
| return set([list(self.column_headers_as_column_keys)[0]]).issubset( | |||
There was a problem hiding this comment.
What does this do? Should we have a comment here maybe?
| for key in self.placeholders: | ||
| # If the key has a different heading due to language, then we need to check that the column_headers | ||
| # in the file have either the same or other language. This is only for email address / phone number | ||
| if key in self.recipient_column_headers_lang_check: # type: ignore |
There was a problem hiding this comment.
So do we allow FR column headers when the request is in EN and vice versa? What exactly is the intersection method doing here?
There was a problem hiding this comment.
yes we allow FR heading and EN request and vice versa.
The intersection says - if the headings that english/french are not in column headers of the file:
Add that header to the result - we know that it is "missing"
