Let a user upload a recipient spreadsheet in either EN or FR #1676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
We need to pass a language filter to decide what error message we will show on a CSV file.
After we merge this code users will be able to upload a file with either "email address" or "adresses courriel" in either FR/ EN context. Same for phone numbers.
The best way to test this code is the following:
https://github.com/cds-snc/notification-utils/blob/task/fix-upload/notifications_utils/recipients.py
https://github.com/cds-snc/notification-utils/blob/task/fix-upload/notifications_utils/columns.py
Here are the use cases I could think of:
I was using success@simulator ..you need to USE an actual email address and ensure the email reaches your inbox.
Eg:
This PR will fail until we merge: cds-snc/notification-utils#245